Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Generalized Closures #1453

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Fix Generalized Closures #1453

wants to merge 6 commits into from

Conversation

Negabinary
Copy link
Contributor

@Negabinary Negabinary commented Jan 8, 2025 •
edited
Loading

Replaces #1435 and #1393, with a simpler approach that more closely matches @jlam55555's generalized closures.

Fixes #1431 and also fixes #1389.

Also fixes #1432

This was referenced Jan 8, 2025
Closed
Closed
@Negabinary Negabinary requested a review from cyrus- January 8, 2025 21:47
@Negabinary Negabinary marked this pull request as ready for review January 8, 2025 21:47
cyrus-
cyrus- requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@cyrus- cyrus- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it so the type annotation on functions post-elaboration is displayed (when show functions is on)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrus- cyrus- cyrus- requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Negabinary @cyrus-